[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <48c927aa-5902-138a-eb93-891325976edd@redhat.com>
Date: Wed, 30 Sep 2020 20:08:52 +0200
From: Paolo Bonzini <pbonzini@...hat.com>
To: Sean Christopherson <sean.j.christopherson@...el.com>,
Ben Gardon <bgardon@...gle.com>
Cc: linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
Cannon Matthews <cannonmatthews@...gle.com>,
Peter Xu <peterx@...hat.com>, Peter Shier <pshier@...gle.com>,
Peter Feiner <pfeiner@...gle.com>,
Junaid Shahid <junaids@...gle.com>,
Jim Mattson <jmattson@...gle.com>,
Yulei Zhang <yulei.kernel@...il.com>,
Wanpeng Li <kernellwp@...il.com>,
Vitaly Kuznetsov <vkuznets@...hat.com>,
Xiao Guangrong <xiaoguangrong.eric@...il.com>
Subject: Re: [PATCH 17/22] kvm: mmu: Support dirty logging for the TDP MMU
On 30/09/20 20:04, Sean Christopherson wrote:
>> + for_each_tdp_mmu_root(kvm, root) {
>> + root_as_id = kvm_mmu_page_as_id(root);
>> + if (root_as_id != slot->as_id)
>> + continue;
> This pattern pops up quite a few times, probably worth adding
>
> #define for_each_tdp_mmu_root_using_memslot(...) \
> for_each_tdp_mmu_root(...) \
> if (kvm_mmu_page_as_id(root) != slot->as_id) {
> } else
>
It's not really relevant that it's a memslot, but
for_each_tdp_mmu_root_using_as_id
makes sense too.
Paolo
Powered by blists - more mailing lists