linux-kernel - Re: [PATCH 2/2] PCI: aardvark: Fix initialization with old Marvell's Arm Trusted Firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200930181753.GA3170411@bogus>
Date:   Wed, 30 Sep 2020 13:17:53 -0500
From:   Rob Herring <robh@...nel.org>
To:     Pali Rohár <pali@...nel.org>
Cc:     Miquel Raynal <miquel.raynal@...tlin.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        linux-arm-kernel@...ts.infradead.org,
        Vinod Koul <vkoul@...nel.org>,
        Tomasz Maciej Nowak <tmn505@...il.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Marek Behún <marek.behun@....cz>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kishon Vijay Abraham I <kishon@...com>
Subject: Re: [PATCH 2/2] PCI: aardvark: Fix initialization with old Marvell's
 Arm Trusted Firmware

On Wed, 02 Sep 2020 16:43:44 +0200, Pali Rohár wrote:
> Old ATF automatically power on pcie phy and does not provide SMC call for
> phy power on functionality which leads to aardvark initialization failure:
> 
> [    0.330134] mvebu-a3700-comphy d0018300.phy: unsupported SMC call, try updating your firmware
> [    0.338846] phy phy-d0018300.phy.1: phy poweron failed --> -95
> [    0.344753] advk-pcie d0070000.pcie: Failed to initialize PHY (-95)
> [    0.351160] advk-pcie: probe of d0070000.pcie failed with error -95
> 
> This patch fixes above failure by ignoring 'not supported' error in
> aardvark driver. In this case it is expected that phy is already power on.
> 
> Signed-off-by: Pali Rohár <pali@...nel.org>
> Fixes: 366697018c9a ("PCI: aardvark: Add PHY support")
> ---
>  drivers/pci/controller/pci-aardvark.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

Reviewed-by: Rob Herring <robh@...nel.org>