linux-kernel - [PATCH] proc: remove a pointless assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 30 Sep 2020 19:53:59 +0100
From:   Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:     Alexey Dobriyan <adobriyan@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-safety@...ts.elisa.tech,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>
Subject: [PATCH] proc: remove a pointless assignment

The variable 'env_start' has only been used for the if condition before
this assignment and is never read after this.
So, remove the assignement.

Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@...il.com>
---
 fs/proc/base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/proc/base.c b/fs/proc/base.c
index aa69c35d904c..238925ff3a80 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -279,7 +279,7 @@ static ssize_t get_mm_cmdline(struct mm_struct *mm, char __user *buf,
 	 * only when it overflows into the environment area.
 	 */
 	if (env_start != arg_end || env_end < env_start)
-		env_start = env_end = arg_end;
+		env_end = arg_end;
 	len = env_end - arg_start;
 
 	/* We're not going to care if "*ppos" has high bits set */
-- 
2.11.0