linux-kernel - Re: [PATCH v3 0/2] Add support for F3A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 Sep 2020 16:17:31 -0400
From:   Lyude Paul <lyude@...hat.com>
To:     Vincent Huang <vincent.huang@...synaptics.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Jiri Kosina <jikos@...nel.org>,
        Andrew Duggan <aduggan@...aptics.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Benjamin Tissoires <btissoir@...hat.com>,
        Chris Heiny <chris.heiny@...aptics.com>
Subject: Re: [PATCH v3 0/2] Add support for F3A

For the whole series:

Reviewed-by: Lyude Paul <lyude@...hat.com>

On Wed, 2020-09-30 at 17:41 +0800, Vincent Huang wrote:
> RMI4 F3A supports the touchpad GPIO function, it's designed to support
> more GPIOs and used on newer touchpads. The patches add support of
> touchpad buttons and rename f30_data to avoid confusion.
> 
> Changes in v2:
> - Combined patch 1 and 2 of v1 to fix bisectability.
> 
> Changes in v3:
> - Fix indentations pointed out by Lyude Paul.
> 
> Vincent Huang (2):
>   Input: synaptics-rmi4 - rename f30_data to gpio_data
>   Input: synaptics-rmi4 - add support for F3A
> 
>  drivers/hid/hid-rmi.c           |   2 +-
>  drivers/input/mouse/synaptics.c |   2 +-
>  drivers/input/rmi4/Kconfig      |   8 ++
>  drivers/input/rmi4/Makefile     |   1 +
>  drivers/input/rmi4/rmi_bus.c    |   3 +
>  drivers/input/rmi4/rmi_driver.h |   1 +
>  drivers/input/rmi4/rmi_f30.c    |  14 +-
>  drivers/input/rmi4/rmi_f3a.c    | 240 ++++++++++++++++++++++++++++++++
>  include/linux/rmi.h             |  11 +-
>  9 files changed, 268 insertions(+), 14 deletions(-)
>  create mode 100644 drivers/input/rmi4/rmi_f3a.c
> 
-- 
Sincerely,
      Lyude Paul (she/her)
      Software Engineer at Red Hat