linux-kernel - RE: [EXT] Re: [PATCH 01/22] mpool: add utility routines and ioctl definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <SN6PR08MB4208CA2400FC06C4939D54F9B3330@SN6PR08MB4208.namprd08.prod.outlook.com>
Date:   Wed, 30 Sep 2020 21:49:36 +0000
From:   "Nabeel Meeramohideen Mohamed (nmeeramohide)" 
        <nmeeramohide@...ron.com>
To:     Hillf Danton <hdanton@...a.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "Steve Moyer (smoyer)" <smoyer@...ron.com>,
        "Greg Becker (gbecker)" <gbecker@...ron.com>,
        "Pierre Labat (plabat)" <plabat@...ron.com>,
        "John Groves (jgroves)" <jgroves@...ron.com>
Subject: RE: [EXT] Re: [PATCH 01/22] mpool: add utility routines and ioctl
 definitions

Hi Hillf,

On Wednesday, September 30, 2020 5:27 AM, Hillf Danton <hdanton@...a.com> wrote:
> On Mon, 28 Sep 2020 11:45:13 -0500 Nabeel M Mohamed wrote:
> >
> > +/* Rate limited version of mp_pr_err(). */
> > +#define mp_pr_rl(_fmt, _err, ...)				\
> > +do {								\
> > +	static unsigned long mp_pr_rl_state;			\
> 
> We do not need to declare a mp_pr_rl_state per use case of mp_pr_rl.

Agreed, will make it a global state to rate limit all messages vs. by call site.

> 
> > +	uint dly = msecs_to_jiffies(333);			\
> 
> printk_timed_ratelimit() needs msec as input instead of tick.

Nice catch, thanks!

Will address both your comments in v2.

Thanks,
Nabeel