linux-kernel - Re: [PATCH] habanalabs/gaudi: use correct define for qman init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200930063803.GB1490382@kroah.com>
Date:   Wed, 30 Sep 2020 08:38:03 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Oded Gabbay <oded.gabbay@...il.com>
Cc:     "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] habanalabs/gaudi: use correct define for qman init

On Tue, Sep 29, 2020 at 11:58:22PM +0300, Oded Gabbay wrote:
> On Fri, Sep 25, 2020 at 8:14 PM Oded Gabbay <oded.gabbay@...il.com> wrote:
> >
> > There was a copy-paste error, and the wrong define was used for
> > initializing the QMAN.
> >
> > Signed-off-by: Oded Gabbay <oded.gabbay@...il.com>
> > ---
> >  drivers/misc/habanalabs/gaudi/gaudi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/gaudi.c
> > index a227806be328..5f65a1691551 100644
> > --- a/drivers/misc/habanalabs/gaudi/gaudi.c
> > +++ b/drivers/misc/habanalabs/gaudi/gaudi.c
> > @@ -2039,7 +2039,7 @@ static void gaudi_init_hbm_dma_qman(struct hl_device *hdev, int dma_id,
> >                 WREG32(mmDMA0_QM_CP_LDMA_SRC_BASE_LO_OFFSET_0 + q_off,
> >                                                         QMAN_LDMA_SRC_OFFSET);
> >                 WREG32(mmDMA0_QM_CP_LDMA_DST_BASE_LO_OFFSET_0 + q_off,
> > -                                                       QMAN_LDMA_SIZE_OFFSET);
> > +                                                       QMAN_LDMA_DST_OFFSET);
> >
> >                 /* Configure RAZWI IRQ */
> >                 dma_qm_err_cfg = HBM_DMA_QMAN_GLBL_ERR_CFG_MSG_EN_MASK;
> > --
> > 2.17.1
> >
> 
> Hi Greg,
> Do you think you can apply this patch directly to your char-misc-next
> branch before the merge window opens ?
> I don't have anything pending and I don't want to send a pull request
> for a single patch.

Sure, I'll be glad to queue it up now.

thanks,

greg k-h