linux-kernel - Re: [PATCH V6] serial: qcom_geni_serial: To correct QUP Version detection logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a0a560c5-8ff5-6c5e-d313-fb77c2631a7e@codeaurora.org>
Date:   Wed, 30 Sep 2020 12:18:14 +0530
From:   Akash Asthana <akashast@...eaurora.org>
To:     Paras Sharma <parashar@...eaurora.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Jiri Slaby <jslaby@...e.com>, linux-arm-msm@...r.kernel.org,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V6] serial: qcom_geni_serial: To correct QUP Version
 detection logic


On 9/30/2020 11:35 AM, Paras Sharma wrote:
> For QUP IP versions 2.5 and above the oversampling rate is
> halved from 32 to 16.
>
> Commit ce734600545f ("tty: serial: qcom_geni_serial: Update
> the oversampling rate") is pushed to handle this scenario.
> But the existing logic is failing to classify QUP Version 3.0
> into the correct group ( 2.5 and above).
>
> As result Serial Engine clocks are not configured properly for
> baud rate and garbage data is sampled to FIFOs from the line.
>
> So, fix the logic to detect QUP with versions 2.5 and above.
>
> Fixes: ce734600545f ("tty: serial: qcom_geni_serial: Update the oversampling rate")
> Signed-off-by: Paras Sharma <parashar@...eaurora.org>
Reviewed-by: Akash Asthana <akashast@...eaurora.org>

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project