linux-kernel - Re: [PATCH v2] block: Fix potential page reference leak in __bio_iov_append_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <24dbab430cbb4464b0915f268229e077@huawei.com>
Date:   Wed, 30 Sep 2020 09:56:49 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     "axboe@...nel.dk" <axboe@...nel.dk>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "kbusch@...nel.org" <kbusch@...nel.org>,
        "johannes.thumshirn@....com" <johannes.thumshirn@....com>,
        "hare@...e.de" <hare@...e.de>
CC:     "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] block: Fix potential page reference leak in
 __bio_iov_append_get_pages()

Friendly ping :)

> When bio_add_hw_page() failed, we left page reference still held in pages from iov_iter_get_pages(). Release these references and also advance the iov_iter according to what we have done successfully yet.
>
> Fixes: 0512a75b98f8 ("block: Introduce REQ_OP_ZONE_APPEND")
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@....com>
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> ---
>  block/bio.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/block/bio.c b/block/bio.c
> index e113073958cb..a323a5446221 100644
> --- a/block/bio.c