linux-kernel - Re: [PATCH][next] lib/mpi: fix off-by-one check on index "no"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200930101253.GB25359@gondor.apana.org.au>
Date:   Wed, 30 Sep 2020 20:12:54 +1000
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Colin King <colin.king@...onical.com>
Cc:     Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Howells <dhowells@...hat.com>,
        Waiman Long <longman@...hat.com>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] lib/mpi: fix off-by-one check on index "no"

On Tue, Sep 29, 2020 at 02:18:28PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> There is an off-by-one range check on the upper limit of
> index "no".  Fix this by changing the > comparison to >=
> 
> Addresses-Coverity: ("Out-of-bounds read")
> Fixes: a8ea8bdd9df9 ("lib/mpi: Extend the MPI library")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  lib/mpi/mpiutil.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Could you resend this with a cc to linux-crypto?

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt