linux-kernel - Re: [PATCH v2 12/12] mm/filemap: Return only head pages from find_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200930123637.GP20115@casper.infradead.org>
Date:   Wed, 30 Sep 2020 13:36:37 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Jan Kara <jack@...e.cz>
Cc:     linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
        Hugh Dickins <hughd@...gle.com>,
        William Kucharski <william.kucharski@...cle.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Yang Shi <yang.shi@...ux.alibaba.com>,
        Dave Chinner <dchinner@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 12/12] mm/filemap: Return only head pages from
 find_get_entries

On Wed, Sep 30, 2020 at 02:15:12PM +0200, Jan Kara wrote:
> On Mon 14-09-20 14:00:42, Matthew Wilcox (Oracle) wrote:
> > All callers now expect head (and base) pages, and can handle multiple
> > head pages in a single batch, so make find_get_entries() behave that way.
> > Also take the opportunity to make it use the pagevec infrastructure
> > instead of open-coding how pvecs behave.  This has the side-effect of
> > being able to append to a pagevec with existing contents, although we
> > don't make use of that functionality anywhere yet.
> > 
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org>
> 
> Looks good to me. You can add:
> 
> Reviewed-by: Jan Kara <jack@...e.cz>
> 
> I'm just curious: What has happened to pagevec_lookup_entries() call in
> invalidate_inode_pages2_range()? Your series appears to be based on a tree
> where the call already does not exist...

That went away in patch 10 of this series.