linux-kernel - Re: [External] [PATCH -next] mm/vmscan: Drop duplicated code in drop_slab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 30 Sep 2020 10:42:46 +0800
From:   Chunxin Zang <zangchunxin@...edance.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Linux Memory Management List <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Kefeng Wang <wangkefeng.wang@...wei.com>,
        Hocko <mhocko@...e.com>
Subject: Re: [External] [PATCH -next] mm/vmscan: Drop duplicated code in drop_slab_node

On Wed, Sep 30, 2020 at 10:07 AM Kefeng Wang <wangkefeng.wang@...wei.com> wrote:
>
> The following patches fix same issue and both add fatal
> signal check in drop_slab_node, kill a duplicated check.
>
>   "mm/vmscan: add a fatal signals check in drop_slab_node"
>   "mm/vmscan: fix infinite loop in drop_slab_node"
>
> Cc: Chunxin Zang <zangchunxin@...edance.com>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
> ---
>  mm/vmscan.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index eae57d092931..980155e257bf 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -699,9 +699,6 @@ void drop_slab_node(int nid)
>         do {
>                 struct mem_cgroup *memcg = NULL;
>
> -               if (fatal_signal_pending(current))
> -                       return;
> -
>                 if (fatal_signal_pending(current))
>                         return;
>
> --
> 2.26.2
>

Yes,  there are the same patch.  Because the 'add a fatal signals
check in drop_slab_node' description is more accurate.
The mail list  please see  https://lkml.org/lkml/2020/9/15/20

Andrew, can you update it ,  thanks so much.

Best wishes
Chunxin Zang