[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e38f9096-8b12-309f-f910-b7fe0843c902@ti.com>
Date: Wed, 30 Sep 2020 16:54:49 +0300
From: Grygorii Strashko <grygorii.strashko@...com>
To: Peter Ujfalusi <peter.ujfalusi@...com>, <nm@...com>,
<t-kristo@...com>, <ssantosh@...nel.org>, <lokeshvutla@...com>
CC: <linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 07/11] firmware: ti_sci: rm: Add new ops for ring
configuration
On 28/09/2020 11:34, Peter Ujfalusi wrote:
> The sysfw ring configuration message has been extended to include virtid
> and asel value for the ring.
> Add the ASEL_VALID to TI_SCI_MSG_VALUE_RM_ALL_NO_ORDER as it is required
> for DMA rings.
>
> Instead of extending the current .config() ops - which would need same
> patch change in the ringacc driver - add ti_sci_msg_rm_ring_cfg struct and
> a new ops using it to configure the ring.
>
> This will allow easy update path in case new members are added for the ring
> configuration.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
> ---
> drivers/firmware/ti_sci.c | 63 ++++++++++++++++++++++++++
> drivers/firmware/ti_sci.h | 7 +++
> include/linux/soc/ti/ti_sci_protocol.h | 31 ++++++++++++-
> 3 files changed, 100 insertions(+), 1 deletion(-)
>
Reviewed-by: Grygorii Strashko <grygorii.strashko@...com>
--
Best regards,
grygorii
Powered by blists - more mailing lists