linux-kernel - Re: [PATCH v2] x86/xen: disable Firmware First mode for correctable memory errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 30 Sep 2020 10:14:58 -0400
From:   boris.ostrovsky@...cle.com
To:     Juergen Gross <jgross@...e.com>, xen-devel@...ts.xenproject.org,
        x86@...nel.org, linux-kernel@...r.kernel.org
Cc:     Stefano Stabellini <sstabellini@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>, stable@...r.kernel.org
Subject: Re: [PATCH v2] x86/xen: disable Firmware First mode for correctable
 memory errors


On 9/25/20 10:07 AM, Juergen Gross wrote:
> When running as Xen dom0 the kernel isn't responsible for selecting the
> error handling mode, this should be handled by the hypervisor.
>
> So disable setting FF mode when running as Xen pv guest. Not doing so
> might result in boot splats like:
>
> [    7.509696] HEST: Enabling Firmware First mode for corrected errors.
> [    7.510382] mce: [Firmware Bug]: Ignoring request to disable invalid MCA bank 2.
> [    7.510383] mce: [Firmware Bug]: Ignoring request to disable invalid MCA bank 3.
> [    7.510384] mce: [Firmware Bug]: Ignoring request to disable invalid MCA bank 4.
> [    7.510384] mce: [Firmware Bug]: Ignoring request to disable invalid MCA bank 5.
> [    7.510385] mce: [Firmware Bug]: Ignoring request to disable invalid MCA bank 6.
> [    7.510386] mce: [Firmware Bug]: Ignoring request to disable invalid MCA bank 7.
> [    7.510386] mce: [Firmware Bug]: Ignoring request to disable invalid MCA bank 8.
>
> Reason is that the HEST ACPI table contains the real number of MCA
> banks, while the hypervisor is emulating only 2 banks for guests.
>
> Cc: stable@...r.kernel.org
> Signed-off-by: Juergen Gross <jgross@...e.com>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>


Applied to for-linus-5.10



-boris