linux-kernel - Re: [PATCH V8 1/4] perf/core: Add PERF_SAMPLE_DATA_PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e974520-6d0f-68af-7eb8-fa52d95ba77b@linux.intel.com>
Date:   Wed, 30 Sep 2020 10:42:38 -0400
From:   "Liang, Kan" <kan.liang@...ux.intel.com>
To:     Stephane Eranian <eranian@...gle.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>, Andi Kleen <ak@...ux.intel.com>,
        Dave Hansen <dave.hansen@...el.com>,
        kirill.shutemov@...ux.intel.com,
        Michael Ellerman <mpe@...erman.id.au>,
        benh@...nel.crashing.org, Paul Mackerras <paulus@...ba.org>
Subject: Re: [PATCH V8 1/4] perf/core: Add PERF_SAMPLE_DATA_PAGE_SIZE



On 9/30/2020 3:15 AM, Stephane Eranian wrote:
>> +static u64 perf_get_page_size(unsigned long addr)
>> +{
>> +       unsigned long flags;
>> +       u64 size;
>> +
>> +       if (!addr)
>> +               return 0;
>> +
>> +       /*
>> +        * Software page-table walkers must disable IRQs,
>> +        * which prevents any tear down of the page tables.
>> +        */
>> +       local_irq_save(flags);
>> +
>> +       size = __perf_get_page_size(current->active_mm, addr);
>> +
> When I tested on my kernel, it panicked because I suspect
> current->active_mm could be NULL. Adding a check for NULL avoided the
> problem. But I suspect this is not the correct solution.
> 

I guess the NULL active_mm should be a rare case. If so, I think it's 
not bad to add a check and return 0 page size.


Thanks,
Kan