[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0a308ee8-abf7-97e4-9814-2156ee56fe8b@gmail.com>
Date: Wed, 30 Sep 2020 17:53:20 +0300
From: Dmitry Osipenko <digetx@...il.com>
To: Nicolin Chen <nicoleotsuka@...il.com>, thierry.reding@...il.com,
joro@...tes.org, krzk@...nel.org
Cc: vdumpa@...dia.com, jonathanh@...dia.com,
linux-tegra@...r.kernel.org, iommu@...ts.linux-foundation.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] iommu/tegra-smmu: Add PCI support
...
> +#ifdef CONFIG_PCI
> + if (!iommu_present(&pci_bus_type)) {
In the previous reply you said that you're borrowing this check from the
arm-smmu driver, but arm-smmu also has a similar check for
platform_bus_type, while Tegra SMMU driver doesn't have it. Hence I'm
objecting the necessity of having this check.
Please give a rationale for having this check in the code. And please
note that cargo cult isn't a rationale to me.
Powered by blists - more mailing lists