linux-kernel - Re: [RFC PATCH v2 1/2] objtool: x86 instruction decoder and big endian cross compiles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200930151951.wwsleh6m4buybqhf@treble>
Date:   Wed, 30 Sep 2020 10:19:51 -0500
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Vasily Gorbik <gor@...ux.ibm.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>,
        Miroslav Benes <mbenes@...e.cz>,
        Alexandre Chartre <alexandre.chartre@...cle.com>,
        Julien Thierry <jthierry@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v2 1/2] objtool: x86 instruction decoder and big
 endian cross compiles

On Wed, Sep 30, 2020 at 02:24:19PM +0200, Vasily Gorbik wrote:
> From: Martin Schwidefsky <schwidefsky@...ibm.com>
> 
> Make the x86 instruction decoder of the objtool usable on big endian
> machines. This is useful for compile tests on non x86, big endian
> hardware.
> 
> Co-developed-by: Vasily Gorbik <gor@...ux.ibm.com>
> [ gor: more endianness problems findings fixes / rebasing ]
> Signed-off-by: Martin Schwidefsky <schwidefsky@...ibm.com>
> Signed-off-by: Vasily Gorbik <gor@...ux.ibm.com>
> ---
>  arch/x86/include/asm/insn.h       | 42 ++++++++++++++
>  arch/x86/lib/insn.c               | 95 +++++++++++++------------------
>  tools/arch/x86/include/asm/insn.h | 42 ++++++++++++++
>  tools/arch/x86/lib/insn.c         | 95 +++++++++++++------------------
>  tools/objtool/arch/x86/special.c  |  2 +-
>  tools/objtool/check.c             |  4 +-
>  tools/objtool/elf.c               | 34 ++++++-----
>  7 files changed, 188 insertions(+), 126 deletions(-)

Can the insn changes be done in a separate patch from the objtool
changes?

Also, 'Masami Hiramatsu <mhiramat@...nel.org>' should be on Cc for the
insn changes since he wrote the original code.

-- 
Josh