linux-kernel - Re: [PATCH v5] Introduce support for Systems Management Driver over WMI for Dell Systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201001190248.GB25055@mtg-dev.jf.intel.com>
Date:   Thu, 1 Oct 2020 12:02:48 -0700
From:   mark gross <mgross@...ux.intel.com>
To:     "Limonciello, Mario" <Mario.Limonciello@...l.com>
Cc:     Divya Bharathi <divya27392@...il.com>,
        "dvhart@...radead.org" <dvhart@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>,
        "Bharathi, Divya" <Divya.Bharathi@...l.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        "Ksr, Prasanth" <Prasanth.Ksr@...l.com>
Subject: Re: [PATCH v5] Introduce support for Systems Management Driver over
 WMI for Dell Systems

On Wed, Sep 30, 2020 at 09:02:38PM +0000, Limonciello, Mario wrote:
> > > +		possible_values:	A file that can be read to obtain the possible
> > > +					values of the <attr>. Values are separated using
> > > +					semi-colon (``;``).
> > why not use set notation from math classes assuming intergers?  i.e.
> > (a, b)  all integers beween a and b but not including a or b (open set)
> > or
> > [a, b] all integerger betwen a and b including and b?  (closed set)
> > 
> > Anyway its ambiguous if the the extremes are included in the set of possible
> > values as written.
> > 
> 
> Enumeration attributes mean that there are fixed values, specifically not integers.
> Integers are in the "integer" type and explained below.
> 
> An example value that would be seen here is possible_values:
> 
> Enabled;Disabled;
I'm ok with this

> 
> > > +
> > > +	security_area_size = calculate_security_buffer();
> > > +	buffer_size = security_area_size + integer_area_size;
> > > +	buffer = kzalloc(buffer_size, GFP_KERNEL);
> > > +	if (!buffer)
> > > +		return -ENOMEM;
> > if you hit this error return I think you will leak the wmi_priv.mutex lock.
> > I think this is a bug.
> 
> Yes, thanks this is a great finding.
> Team will fix in v6 after we have Hans' feedback for v5.
Yay! It makes me feel useful to catch stuff like this.

thanks!

--mark