[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAA_a9xL98fV8Rd=vBLBZBcFCUo8iE6O=Q4WsOcB0Z-tFa1GtoQ@mail.gmail.com>
Date: Thu, 1 Oct 2020 14:11:02 -0700
From: Alex Qiu <xqiu@...gle.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Avi Fishman <avifishman70@...il.com>,
Tali Perry <tali.perry1@...il.com>,
Wolfram Sang <wsa@...nel.org>, Kun Yi <kunyi@...gle.com>,
Benjamin Fair <benjaminfair@...gle.com>,
Joel Stanley <joel@....id.au>,
Tomer Maimon <tmaimon77@...il.com>,
Linux I2C <linux-i2c@...r.kernel.org>,
OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] i2c: npcm7xx: Support changing bus speed using debugfs.
On Thu, Oct 1, 2020 at 11:51 AM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> I see. So, there are following statements:
> - the elaboration is good but I guess needs to be added somewhere in
> form of the documentation
> - the internal schedules or so are not crucial for the upstream (it
> rather sounds like a bribing the judge)
> - the current approach, if I'm not mistaken, is using debugfs, which
> is not ABI and it's good
> - I'm not a maintainer here, but I don't like the approach
>
> Let the maintainer decide.
>
> --
> With Best Regards,
> Andy Shevchenko
Hi Andy,
That makes perfect sense. We may keep it downstream to unblock our own
work if it's not accepted upstream. Thanks for your review!
- Alex Qiu
Powered by blists - more mailing lists