linux-kernel - Re: [PATCH v5 11/15] misc: bcm-vk: add BCM_VK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e7b3a4b6-0662-6ead-8ddb-0cf6324a9bd2@gmail.com>
Date:   Wed, 30 Sep 2020 19:33:37 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Scott Branden <scott.branden@...adcom.com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Olof Johansson <olof@...om.net>
Cc:     Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com,
        Desmond Yan <desmond.yan@...adcom.com>
Subject: Re: [PATCH v5 11/15] misc: bcm-vk: add BCM_VK_QSTATS



On 9/30/2020 6:28 PM, Scott Branden wrote:
> Add BCM_VK_QSTATS Kconfig option to allow for enabling debug VK
> queue statistics.
> 
> These statistics keep track of max, abs_max, and average for the
> messages queues.
> 
> Co-developed-by: Desmond Yan <desmond.yan@...adcom.com>
> Signed-off-by: Desmond Yan <desmond.yan@...adcom.com>
> Signed-off-by: Scott Branden <scott.branden@...adcom.com>
> ---

[snip]

> +#if defined(CONFIG_BCM_VK_QSTATS)
> +	/* clear qstats */
> +	for (i = 0; i < VK_MSGQ_MAX_NR; i++) {
> +		memset(&vk->to_v_msg_chan.qstats[i].qcnts, 0,
> +		       sizeof(vk->to_v_msg_chan.qstats[i].qcnts));
> +		memset(&vk->to_h_msg_chan.qstats[i].qcnts, 0,
> +		       sizeof(vk->to_h_msg_chan.qstats[i].qcnts));
> +	}
> +#endif
>   	/* clear 4096 bits of bitmap */
>   	bitmap_clear(vk->bmap, 0, VK_MSG_ID_BITMAP_SIZE);

It was not clear from looking at this patch how are the statistics 
exposed and how does one actually get them?
-- 
Florian