linux-kernel - Re: [net-next PATCH v1 2/7] net: phy: Introduce phy related fwnode functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201001035854.GB9110@lsv03152.swis.in-blr01.nxp.com>
Date:   Thu, 1 Oct 2020 09:28:54 +0530
From:   Calvin Johnson <calvin.johnson@....nxp.com>
To:     David Miller <davem@...emloft.net>
Cc:     grant.likely@....com, rafael@...nel.org, jeremy.linton@....com,
        andrew@...n.ch, andy.shevchenko@...il.com, f.fainelli@...il.com,
        linux@...linux.org.uk, cristian.sovaiala@....com,
        florinlaurentiu.chiculita@....com, ioana.ciornei@....com,
        madalin.bucur@....nxp.com, heikki.krogerus@...ux.intel.com,
        linux-kernel@...r.kernel.org, linux.cj@...il.com,
        netdev@...r.kernel.org, linux-acpi@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, diana.craciun@....com,
        laurentiu.tudor@....com, hkallweit1@...il.com, kuba@...nel.org
Subject: Re: [net-next PATCH v1 2/7] net: phy: Introduce phy related fwnode
 functions

On Wed, Sep 30, 2020 at 03:03:49PM -0700, David Miller wrote:
> From: Calvin Johnson <calvin.johnson@....nxp.com>
> Date: Wed, 30 Sep 2020 21:34:25 +0530
> 
> > +struct phy_device *fwnode_phy_find_device(struct fwnode_handle *phy_fwnode)
> > +{
> > +	struct device *d;
> > +	struct mdio_device *mdiodev;
> 
> Please use reverse christmas tree ordering for local variables.

Sure. In next rev, I'll make sure all the patches follow this.

Thanks
Calvin