linux-kernel - Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a0afea6-8cbb-3e89-5a4f-89660c942ca3@pengutronix.de>
Date:   Thu, 1 Oct 2020 09:22:03 +0200
From:   Ahmad Fatoum <a.fatoum@...gutronix.de>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Anson Huang <Anson.Huang@....com>,
        Andreas Kemnade <andreas@...nade.info>,
        Stefan Riedmueller <s.riedmueller@...tec.de>,
        Robert Jones <rjones@...eworks.com>,
        Li Yang <leoyang.li@....com>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

Hello Krzysztof,

On 9/30/20 9:01 PM, Krzysztof Kozlowski wrote:
> There are four flavors of TechNexion PICO-IMX6 boards.  They have their
> own DTSes, even though in Dwarf, Nymph and Pi are exactly the same.
> They also have their own bindings so adjust the compatibles to match the
> bindings.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> 
> ---
> 
> Changes since v1:
> 1. None
> ---
>  arch/arm/boot/dts/imx6dl-pico-dwarf.dts  | 2 +-
>  arch/arm/boot/dts/imx6dl-pico-hobbit.dts | 2 +-
>  arch/arm/boot/dts/imx6dl-pico-nymph.dts  | 2 +-
>  arch/arm/boot/dts/imx6dl-pico-pi.dts     | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6dl-pico-dwarf.dts b/arch/arm/boot/dts/imx6dl-pico-dwarf.dts
> index 659a8e8714ea..d85b15a8c127 100644
> --- a/arch/arm/boot/dts/imx6dl-pico-dwarf.dts
> +++ b/arch/arm/boot/dts/imx6dl-pico-dwarf.dts
> @@ -13,5 +13,5 @@
>  
>  / {
>  	model = "TechNexion PICO-IMX6 DualLite/Solo Board and Dwarf baseboard";
> -	compatible = "technexion,imx6dl-pico", "fsl,imx6dl";
> +	compatible = "technexion,imx6dl-pico-dwarf", "fsl,imx6dl";

Could you change this to have all three compatibles ("technexion,imx6dl-pico-dwarf", "technexion,imx6dl-pico",
"fsl,imx6dl") and likewise for the other files? 
That way other firmware that reuses the Linux device tree files and match against the SoM compatible
continues to work after update.

>  };
> diff --git a/arch/arm/boot/dts/imx6dl-pico-hobbit.dts b/arch/arm/boot/dts/imx6dl-pico-hobbit.dts
> index d7403c5c4337..08fedcbcc91b 100644
> --- a/arch/arm/boot/dts/imx6dl-pico-hobbit.dts
> +++ b/arch/arm/boot/dts/imx6dl-pico-hobbit.dts
> @@ -13,5 +13,5 @@
>  
>  / {
>  	model = "TechNexion PICO-IMX6 DualLite/Solo Board and Hobbit baseboard";
> -	compatible = "technexion,imx6dl-pico", "fsl,imx6dl";
> +	compatible = "technexion,imx6dl-pico-hobbit", "fsl,imx6dl";
>  };
> diff --git a/arch/arm/boot/dts/imx6dl-pico-nymph.dts b/arch/arm/boot/dts/imx6dl-pico-nymph.dts
> index b282dbf953aa..32ccfc5d41ce 100644
> --- a/arch/arm/boot/dts/imx6dl-pico-nymph.dts
> +++ b/arch/arm/boot/dts/imx6dl-pico-nymph.dts
> @@ -13,5 +13,5 @@
>  
>  / {
>  	model = "TechNexion PICO-IMX6 DualLite/Solo Board and Nymph baseboard";
> -	compatible = "technexion,imx6dl-pico", "fsl,imx6dl";
> +	compatible = "technexion,imx6dl-pico-nymph", "fsl,imx6dl";
>  };
> diff --git a/arch/arm/boot/dts/imx6dl-pico-pi.dts b/arch/arm/boot/dts/imx6dl-pico-pi.dts
> index b7b1c07f96f3..4590e8ad9a91 100644
> --- a/arch/arm/boot/dts/imx6dl-pico-pi.dts
> +++ b/arch/arm/boot/dts/imx6dl-pico-pi.dts
> @@ -13,5 +13,5 @@
>  
>  / {
>  	model = "TechNexion PICO-IMX6 DualLite/Solo Board and PI baseboard";
> -	compatible = "technexion,imx6dl-pico", "fsl,imx6dl";
> +	compatible = "technexion,imx6dl-pico-pi", "fsl,imx6dl";
>  };
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |