linux-kernel - [PATCH 2/2] RDMA/rtrs: check before free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20201001072703.16256-1-gi-oh.kim@clous.ionos.com>
Date:   Thu,  1 Oct 2020 09:27:03 +0200
From:   Gioh Kim <gi-oh.kim@...ud.ionos.com>
To:     danil.kipnis@...ud.ionos.com, jinpu.wang@...ud.ionos.com
Cc:     linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org,
        Gioh Kim <gi-oh.kim@...ud.ionos.com>
Subject: [PATCH 2/2] RDMA/rtrs: check before free

From: Gioh Kim <gi-oh.kim@...ud.ionos.com>

If rtrs_iu_alloc failed to allocate buffer or map dma,
there are some allocated addresses and some NULL addresses
in the array. rtrs_iu_free should check data before free.

Signed-off-by: Gioh Kim <gi-oh.kim@...ud.ionos.com>
---
 drivers/infiniband/ulp/rtrs/rtrs.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/ulp/rtrs/rtrs.c b/drivers/infiniband/ulp/rtrs/rtrs.c
index 5163e662f86f..ca2d2d3e4192 100644
--- a/drivers/infiniband/ulp/rtrs/rtrs.c
+++ b/drivers/infiniband/ulp/rtrs/rtrs.c
@@ -61,8 +61,12 @@ void rtrs_iu_free(struct rtrs_iu *ius, struct ib_device *ibdev, u32 queue_size)
 
 	for (i = 0; i < queue_size; i++) {
 		iu = &ius[i];
-		ib_dma_unmap_single(ibdev, iu->dma_addr, iu->size, iu->direction);
-		kfree(iu->buf);
+		if (iu->dma_addr) {
+			ib_dma_unmap_single(ibdev, iu->dma_addr, iu->size, iu->direction);
+		}
+		if (iu->buf) {
+			kfree(iu->buf);
+		}
 	}
 	kfree(ius);
 }
-- 
2.20.1