linux-kernel - Re: [PATCH] phy: qcom-qmp: initialize the pointer to NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201001073719.GT2968@vkoul-mobl>
Date:   Thu, 1 Oct 2020 13:07:19 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        kernel test robot <lkp@...el.com>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH] phy: qcom-qmp: initialize the pointer to NULL

On 01-10-20, 00:23, Stephen Boyd wrote:
> Quoting Vinod Koul (2020-10-01 00:09:11)
> > Smatch complains:
> > drivers/phy/qualcomm/phy-qcom-qmp.c:3899 qcom_qmp_phy_probe() error: uninitialized symbol 'dp_cfg'.
> > drivers/phy/qualcomm/phy-qcom-qmp.c:3900 qcom_qmp_phy_probe() error: uninitialized symbol 'dp_serdes'.
> > drivers/phy/qualcomm/phy-qcom-qmp.c:3902 qcom_qmp_phy_probe() error: uninitialized symbol 'usb_cfg'.
> > 
> > This is a warning but not a practical one as dp_cfg, dp_serdes and
> > usb_cfg will be set and used when valid. So we can set the pointers to
> > NULL to quiesce the warnings.
> > 
> > Reported-by: kernel test robot <lkp@...el.com>
> > Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> > Fixes: 52e013d0bffa ("phy: qcom-qmp: Add support for DP in USB3+DP combo phy")
> > Signed-off-by: Vinod Koul <vkoul@...nel.org>
> > ---
> 
> Thanks!
> 
> Reviewed-by: Stephen Boyd <swboyd@...omium.org>

Thanks for quick review, applied and pushed now

-- 
~Vinod