linux-kernel - Re: [PATCH -next] drm/panfrost: simplify the return expression of panfrost_devfreq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKMK7uHQe3PBnNinaGn37s+Cgko1taKcCT3=Yy1uw63pRurOhw@mail.gmail.com>
Date:   Thu, 1 Oct 2020 13:25:03 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     Steven Price <steven.price@....com>
Cc:     Qinglang Miao <miaoqinglang@...wei.com>,
        Rob Herring <robh@...nel.org>,
        Tomeu Vizoso <tomeu.vizoso@...labora.com>,
        Alyssa Rosenzweig <alyssa.rosenzweig@...labora.com>,
        David Airlie <airlied@...ux.ie>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] drm/panfrost: simplify the return expression of panfrost_devfreq_target()

On Thu, Oct 1, 2020 at 12:58 PM Steven Price <steven.price@....com> wrote:
>
> On 21/09/2020 14:10, Qinglang Miao wrote:
> > Simplify the return expression.
> >
> > Signed-off-by: Qinglang Miao <miaoqinglang@...wei.com>
>
> Reviewed-by: Steven Price <steven.price@....com>

As committer/maintainer for this please indicate whether you'll merge
this or not, with just an r-b patches are in an awkward limbo state.
Since Qinglang isn't committer you probably want to merge their
patches, for otherwise they get lost.
-Daniel
>
> > ---
> >   drivers/gpu/drm/panfrost/panfrost_devfreq.c | 7 +------
> >   1 file changed, 1 insertion(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
> > index 8ab025d00..913eaa6d0 100644
> > --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c
> > +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
> > @@ -29,18 +29,13 @@ static int panfrost_devfreq_target(struct device *dev, unsigned long *freq,
> >                                  u32 flags)
> >   {
> >       struct dev_pm_opp *opp;
> > -     int err;
> >
> >       opp = devfreq_recommended_opp(dev, freq, flags);
> >       if (IS_ERR(opp))
> >               return PTR_ERR(opp);
> >       dev_pm_opp_put(opp);
> >
> > -     err = dev_pm_opp_set_rate(dev, *freq);
> > -     if (err)
> > -             return err;
> > -
> > -     return 0;
> > +     return dev_pm_opp_set_rate(dev, *freq);
> >   }
> >
> >   static void panfrost_devfreq_reset(struct panfrost_devfreq *pfdevfreq)
> >
>


-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch