linux-kernel - Re: [PATCH] x86/kvm: hide KVM options from menuconfig when KVM is not compiled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFnufp1-rYvVFykL94r-XLCyO7NDFO6UjPVQi-FG2E=iVKh50Q@mail.gmail.com>
Date:   Thu, 1 Oct 2020 16:19:02 +0200
From:   Matteo Croce <mcroce@...ux.microsoft.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Paolo Bonzini <pbonzini@...hat.com>,
        Sean Christopherson <sean.j.christopherson@...el.com>
Subject: Re: [PATCH] x86/kvm: hide KVM options from menuconfig when KVM is not compiled

On Thu, Oct 1, 2020 at 4:01 PM Vitaly Kuznetsov <vkuznets@...hat.com> wrote:
>
> Matteo Croce <mcroce@...ux.microsoft.com> writes:
>
> > From: Matteo Croce <mcroce@...rosoft.com>
> >
> > Let KVM_WERROR depend on KVM, so it doesn't show in menuconfig alone.
> >
> > Signed-off-by: Matteo Croce <mcroce@...rosoft.com>
>
> I'd even say
>
> Fixes: 4f337faf1c55e ("KVM: allow disabling -Werror")
>

Indeed, thanks

> > ---
> >  arch/x86/kvm/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> > index fbd5bd7a945a..f92dfd8ef10d 100644
> > --- a/arch/x86/kvm/Kconfig
> > +++ b/arch/x86/kvm/Kconfig
> > @@ -66,6 +66,7 @@ config KVM_WERROR
> >       default y if X86_64 && !KASAN
> >       # We use the dependency on !COMPILE_TEST to not be enabled
> >       # blindly in allmodconfig or allyesconfig configurations
> > +     depends on KVM
> >       depends on (X86_64 && !KASAN) || !COMPILE_TEST
> >       depends on EXPERT
> >       help
>
> Reviewed-by: Vitaly Kuznetsov <vkuznets@...hat.com>
>
> --
> Vitaly
>


-- 
per aspera ad upstream