linux-kernel - Re: linux-next: build failure after merge of the hwmon-staging tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201001150944.GA64648@roeck-us.net>
Date:   Thu, 1 Oct 2020 08:09:44 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Vadim Pasternak <vadimp@...dia.com>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the hwmon-staging tree

On Thu, Oct 01, 2020 at 12:53:10PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the hwmon-staging tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/hwmon/pmbus/mp2975.c: In function 'mp2975_probe':
> drivers/hwmon/pmbus/mp2975.c:740:32: error: passing argument 2 of 'pmbus_do_probe' from incompatible pointer type [-Werror=incompatible-pointer-types]
>   740 |  return pmbus_do_probe(client, id, info);
>       |                                ^~
>       |                                |
>       |                                const struct i2c_device_id *
> In file included from drivers/hwmon/pmbus/mp2975.c:13:
> drivers/hwmon/pmbus/pmbus.h:492:73: note: expected 'struct pmbus_driver_info *' but argument is of type 'const struct i2c_device_id *'
>   492 | int pmbus_do_probe(struct i2c_client *client, struct pmbus_driver_info *info);
>       |                                               ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
> drivers/hwmon/pmbus/mp2975.c:740:9: error: too many arguments to function 'pmbus_do_probe'
>   740 |  return pmbus_do_probe(client, id, info);
>       |         ^~~~~~~~~~~~~~
> In file included from drivers/hwmon/pmbus/mp2975.c:13:
> drivers/hwmon/pmbus/pmbus.h:492:5: note: declared here
>   492 | int pmbus_do_probe(struct i2c_client *client, struct pmbus_driver_info *info);
>       |     ^~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   dd38ac315b23 ("hwmon: (pmbus) Add support for MPS Multi-phase mp2975 controller")
> 
Oops, sorry, got caught in API changes. Fixed.

Guenter

> I have used the hwmon-staging tree from next-20200930 for today.
> 
> -- 
> Cheers,
> Stephen Rothwell