[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20201002121317.474c95f0@hermes.local>
Date: Fri, 2 Oct 2020 12:13:17 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Jarod Wilson <jarod@...hat.com>
Cc: linux-kernel@...r.kernel.org, Jay Vosburgh <j.vosburgh@...il.com>,
Veaceslav Falico <vfalico@...il.com>,
Andy Gospodarek <andy@...yhouse.net>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Thomas Davis <tadavis@....gov>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 6/6] bonding: make Kconfig toggle to disable
legacy interfaces
On Fri, 2 Oct 2020 13:40:01 -0400
Jarod Wilson <jarod@...hat.com> wrote:
> By default, enable retaining all user-facing API that includes the use of
> master and slave, but add a Kconfig knob that allows those that wish to
> remove it entirely do so in one shot.
>
> Cc: Jay Vosburgh <j.vosburgh@...il.com>
> Cc: Veaceslav Falico <vfalico@...il.com>
> Cc: Andy Gospodarek <andy@...yhouse.net>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Thomas Davis <tadavis@....gov>
> Cc: netdev@...r.kernel.org
> Signed-off-by: Jarod Wilson <jarod@...hat.com>
> ---
> drivers/net/Kconfig | 12 ++++++++++++
> drivers/net/bonding/bond_main.c | 4 ++--
> drivers/net/bonding/bond_options.c | 4 ++--
> drivers/net/bonding/bond_procfs.c | 8 ++++++++
> drivers/net/bonding/bond_sysfs.c | 14 ++++++++++----
> drivers/net/bonding/bond_sysfs_port.c | 6 ++++--
> 6 files changed, 38 insertions(+), 10 deletions(-)
>
This is problematic. You are printing both old and new values.
Also every distribution will have to enable it.
This looks like too much of change to users.
Powered by blists - more mailing lists