linux-kernel - Re: [PATCH] ASoC: hdac_hdmi: remove cancel_work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <160167211500.21762.13369928255363041989.b4-ty@kernel.org>
Date:   Fri, 02 Oct 2020 22:06:28 +0100
From:   Mark Brown <broonie@...nel.org>
To:     alsa-devel@...a-project.org, Brent Lu <brent.lu@...el.com>
Cc:     linux-kernel@...r.kernel.org, Kai Vehmanen <kai.ve@...r.kernel.org,
        hmanen@...ux.intel.com>, Pierre-Louis Bossart <pierre@...r.kernel.org,
        -louis.bossart@...ux.intel.com>, Takashi Iwai <tiwa@...r.kernel.org,
        i@...e.com>, Guennadi Liakhovetski <guennadi.liakhove@...r.kernel.org,
        tski@...ux.intel.com>, Liam Girdwood <lgirdwood@gma@...r.kernel.org,
        il.com>, Amadeusz Sławiński <amadeuszx.slawin@...r.kernel.org,
        ski@...ux.intel.com>@vger.kernel.org
Subject: Re: [PATCH] ASoC: hdac_hdmi: remove cancel_work_sync in runtime
 suspend

On Wed, 15 Jul 2020 21:01:50 +0800, Brent Lu wrote:
> A deadlock is identified when there are three contexts running at the
> same time:
> - a HDMI jack work which is calling snd_soc_dapm_sync().
> - user space is calling snd_pcm_release() to close pcm device.
> - pm is calling runtime suspend function of HDMI codec driver.
> 
> By removing the clear_dapm_works() invocation in the
> hdac_hdmi_runtime_suspend() function, the snd_pcm_release() could
> always returns from dapm_power_widgets() function call without
> blocking the hdac_hdmi_jack_dapm_work() work thread or being blocked
> by the hdac_hdmi_runtime_suspend() function. The purpose of the jack
> work is to enable/disable the dapm jack pin so it's not necessary to
> cancel the work in runtime suspend function which is usually called
> when pcm device is closed.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: hdac_hdmi: remove cancel_work_sync in runtime suspend
      commit: cec6e41ce094affad3b5f9f5e5aa1f81c66ce682

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark