linux-kernel - Re: [PATCH v13 19/26] mm: Re-introduce do_mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4da742d8-983e-ff24-c74e-3c2de1590a51@intel.com>
Date:   Fri, 2 Oct 2020 15:57:47 -0700
From:   "Yu, Yu-cheng" <yu-cheng.yu@...el.com>
To:     Peter Collingbourne <pcc@...gle.com>
Cc:     x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-doc@...r.kernel.org, linux-mm@...ck.org,
        linux-arch@...r.kernel.org, linux-api@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>,
        Andy Lutomirski <luto@...nel.org>,
        Balbir Singh <bsingharora@...il.com>,
        Borislav Petkov <bp@...en8.de>,
        Cyrill Gorcunov <gorcunov@...il.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Eugene Syromiatnikov <esyr@...hat.com>,
        Florian Weimer <fweimer@...hat.com>,
        "H.J. Lu" <hjl.tools@...il.com>, Jann Horn <jannh@...gle.com>,
        Jonathan Corbet <corbet@....net>,
        Kees Cook <keescook@...omium.org>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Nadav Amit <nadav.amit@...il.com>,
        Oleg Nesterov <oleg@...hat.com>, Pavel Machek <pavel@....cz>,
        Peter Zijlstra <peterz@...radead.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        "Ravi V. Shankar" <ravi.v.shankar@...el.com>,
        Vedvyas Shanbhogue <vedvyas.shanbhogue@...el.com>,
        Dave Martin <Dave.Martin@....com>,
        Weijiang Yang <weijiang.yang@...el.com>,
        Pengfei Xu <pengfei.xu@...el.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v13 19/26] mm: Re-introduce do_mmap_pgoff()

On 10/2/2020 3:52 PM, Peter Collingbourne wrote:
> On Fri, Oct 2, 2020 at 8:58 AM Yu, Yu-cheng <yu-cheng.yu@...el.com> wrote:
>>
>> On 10/1/2020 7:06 PM, Peter Collingbourne wrote:
>>> On Fri, Sep 25, 2020 at 7:57 AM Yu-cheng Yu <yu-cheng.yu@...el.com> wrote:
>>>>
>>>> There was no more caller passing vm_flags to do_mmap(), and vm_flags was
>>>> removed from the function's input by:
>>>>
>>>>       commit 45e55300f114 ("mm: remove unnecessary wrapper function do_mmap_pgoff()").
>>>>
>>>> There is a new user now.  Shadow stack allocation passes VM_SHSTK to
>>>> do_mmap().  Re-introduce the vm_flags and do_mmap_pgoff().
>>>
>>> I would prefer to change the callers to pass the additional 0 argument
>>> instead of bringing the wrapper function back, but if we're going to
>>> bring it back then we should fix the naming (both functions take a
>>> pgoff argument, so the previous name do_mmap_pgoff() was just plain
>>> confusing).
>>>
>>> Peter
>>>
>>
>> Thanks for your feedback.  Here is the updated patch.  I will re-send
>> the whole series later.
>>
>> Yu-cheng
>>
>> ======
>>
>>   From 6a9f1e6bcdb6e599a44d5f58cf4cebd28c4634a2 Mon Sep 17 00:00:00 2001
>> From: Yu-cheng Yu <yu-cheng.yu@...el.com>
>> Date: Wed, 12 Aug 2020 14:01:58 -0700
>> Subject: [PATCH 19/26] mm: Re-introduce do_mmap_pgoff()
> 
> The subject line of the commit message needs to be updated, but aside from that:
> 
> Reviewed-by: Peter Collingbourne <pcc@...gle.com>
> 
> Peter

Thanks for reviewing.  I will fix the subject line.

Yu-cheng