linux-kernel - Re: [PATCH v2] mm: Remove src/dst mm parameter in copy_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201002233257.GN9916@ziepe.ca>
Date:   Fri, 2 Oct 2020 20:32:57 -0300
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Peter Xu <peterx@...hat.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        "Kirill A . Shutemov" <kirill@...temov.name>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2] mm: Remove src/dst mm parameter in copy_page_range()

On Fri, Oct 02, 2020 at 03:26:47PM -0400, Peter Xu wrote:
> Both of the mm pointers are not needed after commit 7a4830c380f3 ("mm/fork:
> Pass new vma pointer into copy_page_range()").
> 
> Jason Gunthorpe also reported that the ordering of copy_page_range() is odd.
> Since working at it, reorder the parameters to be logical, by (1) always put
> the dst_* fields to be before src_* fields, and (2) keep the same type of
> parameters together.
> 
> CC: Jason Gunthorpe <jgg@...pe.ca>
> CC: Andrew Morton <akpm@...ux-foundation.org>
> Reported-by: Kirill A. Shutemov <kirill@...temov.name>
> Signed-off-by: Peter Xu <peterx@...hat.com>
> ---
> v2:
> - further reorder some parameters and line format [Jason]
> ---
>  include/linux/mm.h |   4 +-
>  kernel/fork.c      |   2 +-
>  mm/memory.c        | 139 ++++++++++++++++++++++++---------------------
>  3 files changed, 76 insertions(+), 69 deletions(-)

Thanks, looks more readable to me

Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

Jason