linux-kernel - Re: [PATCH 2/2] PM/hibernate: remove the bogus call to get_gendisk in software

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201002065015.GA9691@lst.de>
Date:   Fri, 2 Oct 2020 08:50:15 +0200
From:   Christoph Hellwig <hch@....de>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Christoph Hellwig <hch@....de>, Tejun Heo <tj@...nel.org>,
        Jens Axboe <axboe@...nel.dk>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Pavel Machek <pavel@....cz>, Len Brown <len.brown@...el.com>,
        Minho Ban <mhban@...sung.com>, cgroups@...r.kernel.org,
        linux-block@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>
Subject: Re: [PATCH 2/2] PM/hibernate: remove the bogus call to get_gendisk
 in software_resume

On Wed, Sep 30, 2020 at 05:45:27PM +0200, Rafael J. Wysocki wrote:
> On Fri, Sep 25, 2020 at 6:15 PM Christoph Hellwig <hch@....de> wrote:
> >
> > get_gendisk grabs a reference on the disk and file operation, so this
> > code will leak both of them while having absolutely no use for the
> > gendisk itself.
> >
> > This effectively reverts commit 2df83fa4bce421f
> > ("PM / Hibernate: Use get_gendisk to verify partition if resume_file is integer format")
> >
> > Signed-off-by: Christoph Hellwig <hch@....de>
> 
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Can you pick it up through the PM tree?  The big rework in this area
I have planned won't land before 5.11 anyway.