linux-kernel - Re: [PATCH -next] PCI: cadence: simplify the return expression of cdns_pcie_host_init_address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201002115430.GC23640@e121166-lin.cambridge.arm.com>
Date:   Fri, 2 Oct 2020 12:54:31 +0100
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Qinglang Miao <miaoqinglang@...wei.com>
Cc:     Tom Joseph <tjoseph@...ence.com>, Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] PCI: cadence: simplify the return expression of
 cdns_pcie_host_init_address_translation()

On Mon, Sep 21, 2020 at 09:10:53PM +0800, Qinglang Miao wrote:
> Simplify the return expression.
> 
> Signed-off-by: Qinglang Miao <miaoqinglang@...wei.com>
> ---
>  drivers/pci/controller/cadence/pcie-cadence-host.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)

Applied to pci/cadence, thanks.

Lorenzo

> diff --git a/drivers/pci/controller/cadence/pcie-cadence-host.c b/drivers/pci/controller/cadence/pcie-cadence-host.c
> index 4550e0d46..811c1cb2e 100644
> --- a/drivers/pci/controller/cadence/pcie-cadence-host.c
> +++ b/drivers/pci/controller/cadence/pcie-cadence-host.c
> @@ -337,7 +337,7 @@ static int cdns_pcie_host_init_address_translation(struct cdns_pcie_rc *rc)
>  	struct resource_entry *entry;
>  	u64 cpu_addr = cfg_res->start;
>  	u32 addr0, addr1, desc1;
> -	int r, err, busnr = 0;
> +	int r, busnr = 0;
>  
>  	entry = resource_list_first_type(&bridge->windows, IORESOURCE_BUS);
>  	if (entry)
> @@ -383,11 +383,7 @@ static int cdns_pcie_host_init_address_translation(struct cdns_pcie_rc *rc)
>  		r++;
>  	}
>  
> -	err = cdns_pcie_host_map_dma_ranges(rc);
> -	if (err)
> -		return err;
> -
> -	return 0;
> +	return cdns_pcie_host_map_dma_ranges(rc);
>  }
>  
>  static int cdns_pcie_host_init(struct device *dev,
> -- 
> 2.23.0
>