linux-kernel - Re: [PATCH -next] PCI: loongson: simplify the return expression of loongson_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201002115737.GD23640@e121166-lin.cambridge.arm.com>
Date:   Fri, 2 Oct 2020 12:57:37 +0100
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Qinglang Miao <miaoqinglang@...wei.com>
Cc:     Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] PCI: loongson: simplify the return expression of
 loongson_pci_probe()

On Mon, Sep 21, 2020 at 09:10:54PM +0800, Qinglang Miao wrote:
> Simplify the return expression.
> 
> Signed-off-by: Qinglang Miao <miaoqinglang@...wei.com>
> ---
>  drivers/pci/controller/pci-loongson.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)

Applied to pci/loongson, thanks.

Lorenzo

> diff --git a/drivers/pci/controller/pci-loongson.c b/drivers/pci/controller/pci-loongson.c
> index 719c19fe2..48169b1e3 100644
> --- a/drivers/pci/controller/pci-loongson.c
> +++ b/drivers/pci/controller/pci-loongson.c
> @@ -183,7 +183,6 @@ static int loongson_pci_probe(struct platform_device *pdev)
>  	struct device_node *node = dev->of_node;
>  	struct pci_host_bridge *bridge;
>  	struct resource *regs;
> -	int err;
>  
>  	if (!node)
>  		return -ENODEV;
> @@ -222,11 +221,7 @@ static int loongson_pci_probe(struct platform_device *pdev)
>  	bridge->ops = &loongson_pci_ops;
>  	bridge->map_irq = loongson_map_irq;
>  
> -	err = pci_host_probe(bridge);
> -	if (err)
> -		return err;
> -
> -	return 0;
> +	return pci_host_probe(bridge);
>  }
>  
>  static struct platform_driver loongson_pci_driver = {
> -- 
> 2.23.0
>