linux-kernel - Re: kzfree script

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4b880899-979f-4d44-bb75-f9e15df09157@linux.com>
Date:   Fri, 2 Oct 2020 17:15:49 +0300
From:   Denis Efremov <efremov@...ux.com>
To:     Julia Lawall <julia.lawall@...ia.fr>
Cc:     cocci@...teme.lip6.fr, linux-kernel@...r.kernel.org
Subject: Re: kzfree script

On 10/2/20 5:13 PM, Julia Lawall wrote:
> 
> 
> On Fri, 2 Oct 2020, Denis Efremov wrote:
> 
>> Hi,
>>
>> On 10/2/20 5:01 PM, Julia Lawall wrote:
>>> Denis,
>>>
>>> In the rule proposing kzfree_sensitive, I think it would be helpful to
>>> also highlight the memset line.
>>
>> What do you mean? It's "highlighted" in context mode. Do you mean adding
>> position argument to memset call and showing this position in the warning
>> messages?
> 
> Yes, that seems to be what I mean.  0-day generated a message from the
> script, and I had to hunt around for the reason why it was doing that.  So
> it would be nice to have the memset highlighted.  It seems that the
> non-patch 0-day messages are generated from the report mode.
> 

Ok, I will send a patch for it.

Thanks,
Denis