linux-kernel - Re: external tool to remove embedded filenames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc3efa9aa8955e15255807fc852a4ad3d8ab7f44.camel@perches.com>
Date:   Fri, 02 Oct 2020 08:13:58 -0700
From:   Joe Perches <joe@...ches.com>
To:     Bhaskar Chowdhury <unixbhaskar@...il.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Andy Whitcroft <apw@...onical.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernelnewbies <kernelnewbies@...nelnewbies.org>
Subject: Re: external tool to remove embedded filenames

( * removing mentors, I originally meant to send that to mentees )

On Fri, 2020-10-02 at 20:19 +0530, Bhaskar Chowdhury wrote:
> On 11:47 Thu 01 Oct 2020, Joe Perches wrote:
> > It's rather unnecessary for files to contain their
> > path/filename in source code comments.
> > 
> > Here's a trivial little script that can remove
> > embedded filenames in c90 style comments from files.
> > 
> > This requires git.
[]
> > Running it on today's -next gives:
> > 
> > $ perl remove_embedded_filenames.pl
> > $ git diff --shortstat
> > 2310 files changed, 354 insertions(+), 4239 deletions(-)
> > 
> > It's also possible to give any filename or path
> > as an argument to the script
> > 
> > For instance:
> > 
> > $ perl remove_embedded_filenames.pl drivers/net

The below was an attachment, it's odd that your
mailer quoted it.

> > #!/usr/bin/perl -w
[]
> > if ($modified && !$quiet) {
> >    print <<EOT;
> > Warning: these changes may not be correct.
> > 
> > These changes should be carefully reviewed manually and not combined with
> > any functional changes.
> > 
> > Compile, build and test your changes.
> > 
> > You should understand and be responsible for all object changes.
> > 
> > Make sure you read Documentation/SubmittingPatches before sending
> > any changes to reviewers, maintainers or mailing lists.
> > EOT
> > }
> 
> Suggestion.... please take those damn EOT lines out of it

No.  What's your actual problem with it?

It's a tool and it may not be perfect.

It merely emits a single message if it removes
filenames from files.