linux-kernel - Re: [PATCH v6 4/5] PCI: only return true when dev io state is really changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52e9ba48-2789-31b8-b80c-23854190c4d4@kernel.org>
Date:   Fri, 2 Oct 2020 12:08:27 -0400
From:   Sinan Kaya <okaya@...nel.org>
To:     Ethan Zhao <haifeng.zhao@...el.com>, bhelgaas@...gle.com,
        oohall@...il.com, ruscur@...sell.cc, lukas@...ner.de,
        andriy.shevchenko@...ux.intel.com, stuart.w.hayes@...il.com,
        mr.nuke.me@...il.com, mika.westerberg@...ux.intel.com
Cc:     linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        ashok.raj@...ux.intel.com, sathyanarayanan.kuppuswamy@...el.com,
        xerces.zhao@...il.com
Subject: Re: [PATCH v6 4/5] PCI: only return true when dev io state is really
 changed

On 9/30/2020 3:05 AM, Ethan Zhao wrote:
> When uncorrectable error happens, AER driver and DPC driver interrupt
> handlers likely call
> 
>    pcie_do_recovery()
>    ->pci_walk_bus()
>      ->report_frozen_detected()
> 
> with pci_channel_io_frozen the same time.

We need some more data on this. If DPC is supported by HW, errors
should be triggered by DPC not AER.

If I remember right, there is a register that tells which AER errors
should be handled by DPC.