linux-kernel - Re: [PATCH 1/1] mfd: sl28cpld: Depend on I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f31606f-c2fa-6c49-4f8f-197010f6a759@infradead.org>
Date:   Fri, 2 Oct 2020 09:18:29 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] mfd: sl28cpld: Depend on I2C

On 10/2/20 1:35 AM, Lee Jones wrote:
> Fixes the following randconfig build error:
> 
>  ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_probe':
>  simple-mfd-i2c.c:(.text+0x48): undefined reference to `__devm_regmap_init_i2c'
>  ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_driver_init':
>  simple-mfd-i2c.c:(.init.text+0x14): undefined reference to `i2c_register_driver'
>  ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_driver_exit':
>  simple-mfd-i2c.c:(.exit.text+0xd): undefined reference to `i2c_del_driver'
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/mfd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index bdf8cb962027b..8b99a13669bfc 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1188,6 +1188,7 @@ config MFD_SIMPLE_MFD_I2C
>  
>  config MFD_SL28CPLD
>  	tristate "Kontron sl28cpld Board Management Controller"
> +	depends on I2C
>  	select MFD_SIMPLE_MFD_I2C
>  	help
>  	  Say yes here to enable support for the Kontron sl28cpld board
> 

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

thanks.
-- 
~Randy