lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202010030015.TiKNyT4Q-lkp@intel.com>
Date:   Sat, 3 Oct 2020 00:30:18 +0800
From:   kernel test robot <lkp@...el.com>
To:     Zong-Zhe Yang <kevin_yang@...ltek.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Kalle Valo <kvalo@...eaurora.org>,
        Yan-Hsuan Chuang <yhchuang@...ltek.com>
Subject: drivers/net/wireless/realtek/rtw88/rtw8822c.c:2456:5: warning:
 variable 'corr_val' set but not used

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   472e5b056f000a778abb41f1e443de58eb259783
commit: ba0fbe236fb8a7b992e82d6eafb03a600f5eba43 rtw88: extract: make 8822c an individual kernel module
date:   5 months ago
config: parisc-randconfig-r024-20201002 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ba0fbe236fb8a7b992e82d6eafb03a600f5eba43
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout ba0fbe236fb8a7b992e82d6eafb03a600f5eba43
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/mm.h:95,
                    from include/linux/bvec.h:13,
                    from include/linux/skbuff.h:17,
                    from include/linux/if_ether.h:19,
                    from include/net/mac80211.h:18,
                    from drivers/net/wireless/realtek/rtw88/main.h:8,
                    from drivers/net/wireless/realtek/rtw88/rtw8822c.c:6:
   include/asm-generic/pgtable.h: In function 'pte_clear_not_present_full':
   arch/parisc/include/asm/pgtable.h:96:9: warning: variable 'old_pte' set but not used [-Wunused-but-set-variable]
      96 |   pte_t old_pte;     \
         |         ^~~~~~~
   arch/parisc/include/asm/pgtable.h:322:34: note: in expansion of macro 'set_pte_at'
     322 | #define pte_clear(mm, addr, xp)  set_pte_at(mm, addr, xp, __pte(0))
         |                                  ^~~~~~~~~~
   include/asm-generic/pgtable.h:202:2: note: in expansion of macro 'pte_clear'
     202 |  pte_clear(mm, address, ptep);
         |  ^~~~~~~~~
   include/asm-generic/pgtable.h: In function '__ptep_modify_prot_commit':
   arch/parisc/include/asm/pgtable.h:96:9: warning: variable 'old_pte' set but not used [-Wunused-but-set-variable]
      96 |   pte_t old_pte;     \
         |         ^~~~~~~
   include/asm-generic/pgtable.h:641:2: note: in expansion of macro 'set_pte_at'
     641 |  set_pte_at(vma->vm_mm, addr, ptep, pte);
         |  ^~~~~~~~~~
   drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function 'rtw8822c_dpk_dc_corr_check':
>> drivers/net/wireless/realtek/rtw88/rtw8822c.c:2456:5: warning: variable 'corr_val' set but not used [-Wunused-but-set-variable]
    2456 |  u8 corr_val, corr_idx;
         |     ^~~~~~~~
--
   In file included from arch/parisc/include/asm/io.h:6,
                    from include/linux/io.h:13,
                    from include/linux/irq.h:20,
                    from arch/parisc/include/asm/hardirq.h:13,
                    from include/linux/hardirq.h:9,
                    from include/linux/interrupt.h:11,
                    from include/linux/pci.h:38,
                    from drivers/net/wireless/realtek/rtw88/pci.c:6:
   include/asm-generic/pgtable.h: In function 'pte_clear_not_present_full':
   arch/parisc/include/asm/pgtable.h:96:9: warning: variable 'old_pte' set but not used [-Wunused-but-set-variable]
      96 |   pte_t old_pte;     \
         |         ^~~~~~~
   arch/parisc/include/asm/pgtable.h:322:34: note: in expansion of macro 'set_pte_at'
     322 | #define pte_clear(mm, addr, xp)  set_pte_at(mm, addr, xp, __pte(0))
         |                                  ^~~~~~~~~~
   include/asm-generic/pgtable.h:202:2: note: in expansion of macro 'pte_clear'
     202 |  pte_clear(mm, address, ptep);
         |  ^~~~~~~~~
   include/asm-generic/pgtable.h: In function '__ptep_modify_prot_commit':
   arch/parisc/include/asm/pgtable.h:96:9: warning: variable 'old_pte' set but not used [-Wunused-but-set-variable]
      96 |   pte_t old_pte;     \
         |         ^~~~~~~
   include/asm-generic/pgtable.h:641:2: note: in expansion of macro 'set_pte_at'
     641 |  set_pte_at(vma->vm_mm, addr, ptep, pte);
         |  ^~~~~~~~~~
   drivers/net/wireless/realtek/rtw88/pci.c: At top level:
>> drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for 'rtw_pci_probe' [-Wmissing-prototypes]
    1477 | int rtw_pci_probe(struct pci_dev *pdev,
         |     ^~~~~~~~~~~~~
>> drivers/net/wireless/realtek/rtw88/pci.c:1557:6: warning: no previous prototype for 'rtw_pci_remove' [-Wmissing-prototypes]
    1557 | void rtw_pci_remove(struct pci_dev *pdev)
         |      ^~~~~~~~~~~~~~
>> drivers/net/wireless/realtek/rtw88/pci.c:1579:6: warning: no previous prototype for 'rtw_pci_shutdown' [-Wmissing-prototypes]
    1579 | void rtw_pci_shutdown(struct pci_dev *pdev)
         |      ^~~~~~~~~~~~~~~~

vim +/corr_val +2456 drivers/net/wireless/realtek/rtw88/rtw8822c.c

5227c2ee453d2f7 Tzu-En Huang 2019-09-09  2452  
5227c2ee453d2f7 Tzu-En Huang 2019-09-09  2453  static u8 rtw8822c_dpk_dc_corr_check(struct rtw_dev *rtwdev, u8 path)
5227c2ee453d2f7 Tzu-En Huang 2019-09-09  2454  {
5227c2ee453d2f7 Tzu-En Huang 2019-09-09  2455  	u16 dc_i, dc_q;
5227c2ee453d2f7 Tzu-En Huang 2019-09-09 @2456  	u8 corr_val, corr_idx;
5227c2ee453d2f7 Tzu-En Huang 2019-09-09  2457  
5227c2ee453d2f7 Tzu-En Huang 2019-09-09  2458  	rtw_write32(rtwdev, REG_RXSRAM_CTL, 0x000900f0);
5227c2ee453d2f7 Tzu-En Huang 2019-09-09  2459  	dc_i = (u16)rtw_read32_mask(rtwdev, REG_STAT_RPT, GENMASK(27, 16));
5227c2ee453d2f7 Tzu-En Huang 2019-09-09  2460  	dc_q = (u16)rtw_read32_mask(rtwdev, REG_STAT_RPT, GENMASK(11, 0));
5227c2ee453d2f7 Tzu-En Huang 2019-09-09  2461  
5227c2ee453d2f7 Tzu-En Huang 2019-09-09  2462  	if (dc_i & BIT(11))
5227c2ee453d2f7 Tzu-En Huang 2019-09-09  2463  		dc_i = 0x1000 - dc_i;
5227c2ee453d2f7 Tzu-En Huang 2019-09-09  2464  	if (dc_q & BIT(11))
5227c2ee453d2f7 Tzu-En Huang 2019-09-09  2465  		dc_q = 0x1000 - dc_q;
5227c2ee453d2f7 Tzu-En Huang 2019-09-09  2466  
5227c2ee453d2f7 Tzu-En Huang 2019-09-09  2467  	rtw_write32(rtwdev, REG_RXSRAM_CTL, 0x000000f0);
5227c2ee453d2f7 Tzu-En Huang 2019-09-09  2468  	corr_idx = (u8)rtw_read32_mask(rtwdev, REG_STAT_RPT, GENMASK(7, 0));
5227c2ee453d2f7 Tzu-En Huang 2019-09-09  2469  	corr_val = (u8)rtw_read32_mask(rtwdev, REG_STAT_RPT, GENMASK(15, 8));
5227c2ee453d2f7 Tzu-En Huang 2019-09-09  2470  
5227c2ee453d2f7 Tzu-En Huang 2019-09-09  2471  	if (dc_i > 200 || dc_q > 200 || corr_idx < 40 || corr_idx > 65)
5227c2ee453d2f7 Tzu-En Huang 2019-09-09  2472  		return 1;
5227c2ee453d2f7 Tzu-En Huang 2019-09-09  2473  	else
5227c2ee453d2f7 Tzu-En Huang 2019-09-09  2474  		return 0;
5227c2ee453d2f7 Tzu-En Huang 2019-09-09  2475  

:::::: The code at line 2456 was first introduced by commit
:::::: 5227c2ee453d2f778192d8bb0f1a6072892aaa8e rtw88: 8822c: add SW DPK support

:::::: TO: Tzu-En Huang <tehuang@...ltek.com>
:::::: CC: Kalle Valo <kvalo@...eaurora.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (34251 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ