linux-kernel - Re: [RFC PATCH 22/22] x86/fpu/xstate: Introduce boot-parameters for control some state component support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2497634d-162e-98d0-d51b-15265616d036@intel.com>
Date:   Fri, 2 Oct 2020 10:25:09 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     "Chang S. Bae" <chang.seok.bae@...el.com>, tglx@...utronix.de,
        mingo@...nel.org, bp@...e.de, luto@...nel.org, x86@...nel.org
Cc:     len.brown@...el.com, jing2.liu@...el.com, ravi.v.shankar@...el.com,
        linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [RFC PATCH 22/22] x86/fpu/xstate: Introduce boot-parameters for
 control some state component support

On 10/1/20 1:39 PM, Chang S. Bae wrote:
> +		if ((custom & XFEATURE_MASK_XTILE) != XFEATURE_MASK_XTILE) {
> +			pr_warn("x86/fpu: Disable 0x%x components due to incorrect setup\n",
> +				XFEATURE_MASK_XTILE);
> +			custom &= ~(XFEATURE_MASK_XTILE);
> +		}

Saying "incorrect setup" is pretty much just wasting the bytes.  We
might as well just say "disabling due to random error", or "disabling
due to the easter bunny".  Each are equally actionable.  How about:

"error in xstate.disable parameter.  Additionally disabling '%s'".