linux-kernel - Re: [PATCH ] scsi: page warning: 'page' may be used uninitialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0E12A198-4C8D-4A24-946C-CF9DC74500AB@oracle.com>
Date:   Fri, 2 Oct 2020 13:08:06 -0500
From:   John Donnelly <john.p.donnelly@...cle.com>
To:     Mike Christie <michael.christie@...cle.com>
Cc:     linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
        martin.petersen@...cle.com, bstroesser@...fujitsu.com
Subject: Re: [PATCH ] scsi: page warning: 'page' may be used uninitialized



> On Oct 2, 2020, at 1:01 PM, Mike Christie <michael.christie@...cle.com> wrote:
> 
> On 9/23/20 7:19 PM, john.p.donnelly@...cle.com wrote:
>> From: John Donnelly <john.p.donnelly@...cle.com>
>> 
>> corrects: drivers/target/target_core_user.c:688:6: warning: 'page' may be used
>> uninitialized
>> 
>> Fixes: 3c58f737231e ("scsi: target: tcmu: Optimize use of
>> flush_dcache_page")
>> 
>> To: linux-scsi@...r.kernel.org
>> Cc: Mike Christie <michael.christie@...cle.com>
>> Signed-off-by: John Donnelly <john.p.donnelly@...cle.com>
>> ---
>> drivers/target/target_core_user.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
>> index 9b7592350502..86b28117787e 100644
>> --- a/drivers/target/target_core_user.c
>> +++ b/drivers/target/target_core_user.c
>> @@ -681,7 +681,7 @@ static void scatter_data_area(struct tcmu_dev *udev,
>> 	void *from, *to = NULL;
>> 	size_t copy_bytes, to_offset, offset;
>> 	struct scatterlist *sg;
>> -	struct page *page;
>> +	struct page *page = NULL;
>> 
>> 	for_each_sg(data_sg, sg, data_nents, i) {
>> 		int sg_remaining = sg->length;
>> 
> 
> Looks ok for now. In the next kernel we can do the more invasive approach and
> add a new struct/helpers to make the code cleaner and fix it properly.
> 
> Acked-by: Mike Christie <michael.christie@...cle.com>


Hi 

Thank you.

I am not always on the email dlists .. Please do the right thing .