linux-kernel - Re: [PATCH v5 2/2] power: supply: bq256xx: Introduce the BQ256XX charger driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201003105448.eqeyfpr7dugsp4in@earth.universe>
Date:   Sat, 3 Oct 2020 12:54:48 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Ricardo Rivera-Matos <r-rivera-matos@...com>
Cc:     robh+dt@...nel.org, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        dmurphy@...com
Subject: Re: [PATCH v5 2/2] power: supply: bq256xx: Introduce the BQ256XX
 charger driver

Hi Ricardo,

On Thu, Oct 01, 2020 at 04:40:34PM -0500, Ricardo Rivera-Matos wrote:
> The BQ256XX family of devices are highly integrated buck chargers
> for single cell batteries.
> 
> Signed-off-by: Ricardo Rivera-Matos <r-rivera-matos@...com>
> 
> v5 - adds power_supply_put_battery_info() and devm_add_action_or_reset() calls
> ---

changes look good, but you are still missing
usb_unregister_notifier() calls on drival removal.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)