linux-kernel - Re: [PATCH 1/7] power: supply: bq24257: skip 'struct acpi_device_id' when !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201003202919.mj4vvwuckgyxbyea@earth.universe>
Date:   Sat, 3 Oct 2020 22:29:19 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Jonathan Bakker <xc-racer2@...e.ca>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/7] power: supply: bq24257: skip 'struct acpi_device_id'
 when !CONFIG_ACPI

Hi,

Thanks for the cleanup, I queued all 7 patches.

-- Sebastian

On Fri, Sep 11, 2020 at 06:27:23PM +0200, Krzysztof Kozlowski wrote:
> Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, the
> struct acpi_device_id becomes unused:
> 
>   drivers/power/supply/bq24257_charger.c:1155:36: warning:
>     'bq24257_acpi_match' defined but not used [-Wunused-const-variable=]
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  drivers/power/supply/bq24257_charger.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/power/supply/bq24257_charger.c b/drivers/power/supply/bq24257_charger.c
> index 8e60cb0f3c3f..96cb3290bcaa 100644
> --- a/drivers/power/supply/bq24257_charger.c
> +++ b/drivers/power/supply/bq24257_charger.c
> @@ -1152,6 +1152,7 @@ static const struct of_device_id bq24257_of_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, bq24257_of_match);
>  
> +#ifdef CONFIG_ACPI
>  static const struct acpi_device_id bq24257_acpi_match[] = {
>  	{ "BQ242500", BQ24250 },
>  	{ "BQ242510", BQ24251 },
> @@ -1159,6 +1160,7 @@ static const struct acpi_device_id bq24257_acpi_match[] = {
>  	{},
>  };
>  MODULE_DEVICE_TABLE(acpi, bq24257_acpi_match);
> +#endif
>  
>  static struct i2c_driver bq24257_driver = {
>  	.driver = {

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)