linux-kernel - Re: [PATCH] test_power: add missing newlines when printing parameters by sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 3 Oct 2020 23:50:29 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Xiongfeng Wang <wangxiongfeng2@...wei.com>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] test_power: add missing newlines when printing
 parameters by sysfs

Hi,

On Sat, Oct 03, 2020 at 02:43:09PM -0700, Joe Perches wrote:
> On Sat, 2020-10-03 at 23:23 +0200, Sebastian Reichel wrote:
> > On Fri, Sep 04, 2020 at 02:09:58PM +0800, Xiongfeng Wang wrote:
> > > When I cat some module parameters by sysfs, it displays as follows.
> > > It's better to add a newline for easy reading.
> []
> > > root@...kaller:~# cd /sys/module/test_power/parameters/
> > > root@...kaller:/sys/module/test_power/parameters# cat ac_online
> > > onroot@...kaller:/sys/module/test_power/parameters# cat battery_present
> > > trueroot@...kaller:/sys/module/test_power/parameters# cat battery_health
> > > goodroot@...kaller:/sys/module/test_power/parameters# cat battery_status
> > > dischargingroot@...kaller:/sys/module/test_power/parameters# cat battery_technology
> > > LIONroot@...kaller:/sys/module/test_power/parameters# cat usb_online
> > > onroot@...kaller:/sys/module/test_power/parameters#
> > > 
> > > Signed-off-by: Xiongfeng Wang <wangxiongfeng2@...wei.com>
> > > ---
> > 
> > Thanks, queued.
> []
> > > diff --git a/drivers/power/supply/test_power.c b/drivers/power/supply/test_power.c
> []
> > > @@ -353,6 +353,7 @@ static int param_set_ac_online(const char *key, const struct kernel_param *kp)
> > >  static int param_get_ac_online(char *buffer, const struct kernel_param *kp)
> > >  {
> > >  	strcpy(buffer, map_get_key(map_ac_online, ac_online, "unknown"));
> > > +	strcat(buffer, "\n");
> > >  	return strlen(buffer);
> > >  }
> 
> All of these would be better as sprintf(buffer, "%s\n", <whatever>)
> so the output is scanned just once instead of scanned three times.

Agreed. Anybody willing to send a patch? :)

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)