linux-kernel - Re: [PATCH] i2c: pxa: move to generic GPIO recovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dde8b782-9193-a044-a328-98955e9fa35e@microchip.com>
Date:   Sat, 3 Oct 2020 22:46:13 +0000
From:   <Codrin.Ciubotariu@...rochip.com>
To:     <linux@...linux.org.uk>
CC:     <linux-i2c@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <wsa@...nel.org>,
        <alpawi@...zon.com>
Subject: Re: [PATCH] i2c: pxa: move to generic GPIO recovery

>>   static void i2c_pxa_unprepare_recovery(struct i2c_adapter *adap)
>> @@ -1325,8 +1320,6 @@ static void i2c_pxa_unprepare_recovery(struct i2c_adapter *adap)
>>                i2c_pxa_do_reset(i2c);
>>        }
>>
>> -     WARN_ON(pinctrl_select_state(i2c->pinctrl, i2c->pinctrl_default));
>> -
> 
> This won't fly. We need to put the pinctrl back into i2c mode _before_
> we re-enable the I2C module, otherwise the I2C block will see logic 0
> on both SCL and SDA which could confuse the block.

Right, I will add it back.

Best regards,
Codrin