linux-kernel - Re: [PATCH AUTOSEL 5.8 08/29] net: dsa: microchip: look for phy-mode in port nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201004124608.GJ2415204@sasha-vm>
Date:   Sun, 4 Oct 2020 08:46:08 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Helmut Grohne <helmut.grohne@...enta.de>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "David S . Miller" <davem@...emloft.net>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH AUTOSEL 5.8 08/29] net: dsa: microchip: look for phy-mode
 in port nodes

On Tue, Sep 29, 2020 at 07:56:30AM +0200, Helmut Grohne wrote:
>Hi Sascha,
>
>On Tue, Sep 29, 2020 at 03:30:05AM +0200, Sasha Levin wrote:
>> From: Helmut Grohne <helmut.grohne@...enta.de>
>>
>> [ Upstream commit edecfa98f602a597666e3c5cab2677ada38d93c5 ]
>>
>> Documentation/devicetree/bindings/net/dsa/dsa.txt says that the phy-mode
>> property should be specified on port nodes. However, the microchip
>> drivers read it from the switch node.
>>
>> Let the driver use the per-port property and fall back to the old
>> location with a warning.
>>
>> Fix in-tree users.
>
>I don't think this patch is useful for stable users. It corrects a
>device tree layout issue. Any existing users of the functionality will
>have an odd, but working device tree and that will continue working
>(with a warning) after applying this patch. It just has a property on
>the "wrong" node. I don't think I'd like to update my device tree in a
>stable update.

I've dropped it, thanks!

-- 
Thanks,
Sasha