linux-kernel - RE: [PATCH 1/2] scsi: ufs: Add DeepSleep feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 4 Oct 2020 14:24:00 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Adrian Hunter <adrian.hunter@...el.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Alim Akhtar <alim.akhtar@...sung.com>
Subject: RE: [PATCH 1/2] scsi: ufs: Add DeepSleep feature

Please ignore - I was confused with pre-fetch.
Sorry,
Avri

> -----Original Message-----
> From: Avri Altman
> Sent: Sunday, October 4, 2020 10:21 AM
> To: 'Adrian Hunter' <adrian.hunter@...el.com>; Martin K . Petersen
> <martin.petersen@...cle.com>; James E . J . Bottomley <jejb@...ux.ibm.com>
> Cc: linux-scsi@...r.kernel.org; linux-kernel@...r.kernel.org; Alim Akhtar
> <alim.akhtar@...sung.com>
> Subject: RE: [PATCH 1/2] scsi: ufs: Add DeepSleep feature
> 
> > +       /*
> > +        * DeepSleep requires the Immediate flag. DeepSleep state is actually
> > +        * entered when the link state goes to Hibern8.
> > +        */
> > +       if (pwr_mode == UFS_DEEPSLEEP_PWR_MODE)
> > +               cmd[1] = 1;
> Shouldn't it be bit1, i.e. cmd[1] = 2 ?
> 
> >         cmd[4] = pwr_mode << 4;
> >