linux-kernel - Re: [PATCH][next] net: phy: dp83869: fix unsigned comparisons against less than zero values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20201003.170914.694797784124863729.davem@davemloft.net>
Date:   Sat, 03 Oct 2020 17:09:14 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     andrew@...n.ch, hkallweit1@...il.com, kuba@...nel.org,
        dmurphy@...com, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] net: phy: dp83869: fix unsigned comparisons
 against less than zero values

From: Colin King <colin.king@...onical.com>
Date: Fri,  2 Oct 2020 17:54:22 +0100

> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently the comparisons of u16 integers value and sopass_val with
> less than zero for error checking is always false because the values
> are unsigned. Fix this by making these variables int.  This does not
> affect the shift and mask operations performed on these variables
> 
> Addresses-Coverity: ("Unsigned compared against zero")
> Fixes: 49fc23018ec6 ("net: phy: dp83869: support Wake on LAN")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thank you.