linux-kernel - Re: [PATCH] net: mvneta: fix double free of txq->buf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20201004.150831.1030602377050100130.davem@davemloft.net>
Date:   Sun, 04 Oct 2020 15:08:31 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     trix@...hat.com
Cc:     thomas.petazzoni@...tlin.com, kuba@...nel.org,
        natechancellor@...il.com, ndesaulniers@...gle.com,
        ezequiel.garcia@...e-electrons.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, clang-built-linux@...glegroups.com
Subject: Re: [PATCH] net: mvneta: fix double free of txq->buf

From: trix@...hat.com
Date: Sat,  3 Oct 2020 11:51:21 -0700

> From: Tom Rix <trix@...hat.com>
> 
> clang static analysis reports this problem:
> 
> drivers/net/ethernet/marvell/mvneta.c:3465:2: warning:
>   Attempt to free released memory
>         kfree(txq->buf);
>         ^~~~~~~~~~~~~~~
> 
> When mvneta_txq_sw_init() fails to alloc txq->tso_hdrs,
> it frees without poisoning txq->buf.  The error is caught
> in the mvneta_setup_txqs() caller which handles the error
> by cleaning up all of the txqs with a call to
> mvneta_txq_sw_deinit which also frees txq->buf.
> 
> Since mvneta_txq_sw_deinit is a general cleaner, all of the
> partial cleaning in mvneta_txq_sw_deinit()'s error handling
> is not needed.
> 
> Fixes: 2adb719d74f6 ("net: mvneta: Implement software TSO")
> Signed-off-by: Tom Rix <trix@...hat.com>

Applied and queued up for -stable, thank you.