linux-kernel - Re: [PATCH] leds: lm3697: Fix out-of-bound access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MIu0jNf--3-2@tutanota.com>
Date:   Mon, 5 Oct 2020 20:29:55 +0200 (CEST)
From:   ultracoolguy@...anota.com
To:     Pavel Machek <pavel@....cz>
Cc:     Dmurphy <dmurphy@...com>, Alexander Dahl <post@...pocky.de>,
        Marek Behun <kabel@...ckhole.sk>,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        Linux Leds <linux-leds@...r.kernel.org>
Subject: Re: [PATCH] leds: lm3697: Fix out-of-bound access

This: 

led->num_banks = count; 

Has to be below devm_kzalloc. Else, it's NULL.
Oct 5, 2020, 17:32 by pavel@....cz:

> Hi!
>
>> Agh. I added the Signed-off-by in an earlier non-published version of the commit, but forgot to add it back. But that doesn't really excuses me.
>>
>> I attached the (hopefully) final version of this patch.  Pavel, I'll send the struct rename separately after I submit this. 
>>
>
> Thanks, I applied it with ... some tweaks. I hope I did not break it,
> and would not mind testing.
>
> Best regards,
>  Pavel
>  
>
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
>