linux-kernel - Re: [PATCH v3] checkpatch: add new warnings to author signoff checks.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1ca28e77e8e3bfa7aadf3efa8ed70f97a9d369c.camel@perches.com>
Date:   Mon, 05 Oct 2020 14:09:45 -0700
From:   Joe Perches <joe@...ches.com>
To:     Dwaipayan Ray <dwaipayanray1@...il.com>
Cc:     linux-kernel-mentees@...ts.linuxfoundation.org,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] checkpatch: add new warnings to author signoff
 checks.

On Tue, 2020-10-06 at 01:37 +0530, Dwaipayan Ray wrote:
> On Tue, Oct 6, 2020 at 1:07 AM Joe Perches <joe@...ches.com> wrote:
> > On Tue, 2020-10-06 at 00:54 +0530, Dwaipayan Ray wrote:
> > > The author signed-off-by checks are currently very vague.
> > > Cases like same name or same address are not handled separately.
> > 
> > When you run tests for this, how many mismatches are
> > caused by name formatting changes like:
> > 
> > From: "Developer, J. Random" <jrd@...corp.com>
> > ...
> > Signed-off-by: "J. Random Developer" <jrd@...corp.com>?
> > 
> > Should these differences generate a warning?
> > 
> 
> Hi,
> I ran my tests on non merge commits between v5.7 and v5.8.
> 
> There were a total of 250 NO_AUTHOR_SIGN_OFF Warnings
> 
> 203 of these were email address mismatches.
> 32 of these were name mismatches.
> 
> So for the name mismatches, the typical cases are like:
> 
> 'From: tannerlove <tannerlove@...gle.com>' != 'Signed-off-by: Tanner
> Love <tannerlove@...gle.com>'
> 'From: "朱灿灿" <zhucancan@...o.com>' != 'Signed-off-by: zhucancan
> <zhucancan@...o.com>'
> 'From: Yuval Basson <ybason@...vell.com>' != 'Signed-off-by: Yuval
> Bason <ybason@...vell.com>'
> 'From: allen <allen.chen@....com.tw>' != 'Signed-off-by: Allen Chen
> <allen.chen@....com.tw>'
> 
> I didn't find the exact formatting change you mentioned in my commit range.
> But I did find something like:
> 
> 'From: "Paul A. Clarke" <pc@...ibm.com>' != 'Signed-off-by: Paul
> Clarke <pc@...ibm.com>'
> 
> So it's like some have parts of their names removed, some have language
> conflicts, and yet some have well different spellings, or initials,
> etc. It's like
> a wide variety of things happening here.
> 
> I think considering these, it should be warned about, and let people know
> that there might be something wrong going on.
> 
> What do you think?

Except for comments and quotes like:

	From: J. Random Developer (BigCorp) <jrd@...corp.com>
	Signed-off-by: "J. Random Developer" <jrd@...corp.com>

I think any time there's a mismatch, there
should be a warning emitted.

That includes any subaddress detail difference.